Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13175 to look at the new patch set (#2). Change subject: [util] modernize signature of Cache interface methods ...................................................................... [util] modernize signature of Cache interface methods Updated the signature of the Lookup() and Insert() methods of the Cache interface to return UniqueHandle. That helps in automating reference counting for the cached items. Also, Release() and Free() methods have been moved into the protected section. With UniqueHandle returned from Lookup() and Insert(), Release() and Free() are no longer required to be the public part of the Cache's interface. Change-Id: I31518cdfa269e6806aa5dda180956896d8cb3404 --- M src/kudu/cfile/block_cache.cc M src/kudu/cfile/block_cache.h M src/kudu/cfile/block_handle.h M src/kudu/cfile/cfile-test.cc M src/kudu/codegen/code_cache.cc M src/kudu/util/cache-bench.cc M src/kudu/util/cache-test.cc M src/kudu/util/cache.cc M src/kudu/util/cache.h M src/kudu/util/file_cache-test.cc M src/kudu/util/file_cache.cc M src/kudu/util/nvm_cache.cc M src/kudu/util/ttl_cache.h 13 files changed, 180 insertions(+), 213 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/13175/2 -- To view, visit http://gerrit.cloudera.org:8080/13175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I31518cdfa269e6806aa5dda180956896d8cb3404 Gerrit-Change-Number: 13175 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120)