Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13175 )
Change subject: [util] modernize signature of Cache interface methods ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13175/2/src/kudu/codegen/code_cache.cc File src/kudu/codegen/code_cache.cc: http://gerrit.cloudera.org:8080/#/c/13175/2/src/kudu/codegen/code_cache.cc@83 PS2, Line 83: memcpy(cache_->MutableValue(&pending), &val, val_len); > The idea was to hide raw handles from the Cache's interface. Using UniqueP Ah, regarding the original question: nope, that's not an overload, that's just taking address of the std::unique_ptr instance. -- To view, visit http://gerrit.cloudera.org:8080/13175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31518cdfa269e6806aa5dda180956896d8cb3404 Gerrit-Change-Number: 13175 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Apr 2019 01:32:16 +0000 Gerrit-HasComments: Yes
