Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13196 )
Change subject: [util] interface to invalidate cache entries ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.h@266 PS2, Line 266: For example, in case of : // multi-shard cache, when the 'iteration_func' returns 'false', : // the invalidation at current shard stops and switches to the next : // non-yet-processed shard, if any is present. An alternative would be to reduce the two numeric arguments into a single boolean that describes whether any valid entries had been encountered. That would support the TTL cache use case while reducing complexity here. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/13196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e340c3270b5580114151cdd40afe82576c18099 Gerrit-Change-Number: 13196 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 01 May 2019 16:19:49 +0000 Gerrit-HasComments: Yes
