Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13196 )
Change subject: [util] interface to invalidate cache entries ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.cc File src/kudu/util/cache.cc: http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.cc@63 PS2, Line 63: const Cache::ValidityFunc Cache::kInvalidateAllEntriesFunc = []( : Slice /* key */, Slice /* value */) { : return false; : }; : : const Cache::IterationFunc Cache::kIterateOverAllEntriesFunc = []( : size_t /* valid_entries_num */, size_t /* valid_entries_num */) { : return true; : }; > These seem more expressive than they need to be for the purpose of invalida Ah, looking at https://gerrit.cloudera.org/c/13201/5/src/kudu/util/ttl_cache.h, looks like the answer is yes. -- To view, visit http://gerrit.cloudera.org:8080/13196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e340c3270b5580114151cdd40afe82576c18099 Gerrit-Change-Number: 13196 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 01 May 2019 19:31:34 +0000 Gerrit-HasComments: Yes
