Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13201 )
Change subject: [TTL cache] add periodic scrubbing thread ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/13201/6/src/kudu/util/ttl_cache.h File src/kudu/util/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/13201/6/src/kudu/util/ttl_cache.h@261 PS6, Line 261: // A reference to avoid passing 'this' into the capture of the cache : // invalidation control below. : const auto& max_entries_per_pass = max_scrubbed_entries_per_pass_num_; > What tangible difference does it make whether we capture 'this' or not? I c It's a good question. I'm not sure there is any tangible difference. At some point I tried to access the max_scrubbed_entries_per_pass_num_ member from within the lambda, but compiler reported an error, so I created the const reference variable. I'll see how it works with capturing 'this' or just 'this->max_scrubbed_entries_per_pass_num_'. -- To view, visit http://gerrit.cloudera.org:8080/13201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3bbbcf6211930a5501a03d6a47f3d911118946c Gerrit-Change-Number: 13201 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 02 May 2019 04:03:39 +0000 Gerrit-HasComments: Yes
