Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13201 )
Change subject: [TTL cache] add periodic scrubbing thread ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/13201/7/src/kudu/util/ttl_cache-test.cc File src/kudu/util/ttl_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/13201/7/src/kudu/util/ttl_cache-test.cc@523 PS7, Line 523: // they must have been removed from the cache's lookup t > I was not sure whether 64 is a good number of threads by default, but I wan I guess my question was more along the lines of, "Why is the distinction between 16 and 64 important for slow tests / TSAN/ASAN?" Will this fail if we used 64 in all build modes? Or is this more just trying to avoid parameterization? Coming back to this test a year from now, I'm not sure I'd follow the rationale for the separation. Could you add a comment explaining? http://gerrit.cloudera.org:8080/#/c/13201/8/src/kudu/util/ttl_cache-test.cc File src/kudu/util/ttl_cache-test.cc: http://gerrit.cloudera.org:8080/#/c/13201/8/src/kudu/util/ttl_cache-test.cc@570 PS8, Line 570: const auto thread_idx = i; nit: no longer need this -- To view, visit http://gerrit.cloudera.org:8080/13201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3bbbcf6211930a5501a03d6a47f3d911118946c Gerrit-Change-Number: 13201 Gerrit-PatchSet: 8 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 03 May 2019 00:41:39 +0000 Gerrit-HasComments: Yes
