Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13196 )
Change subject: [util] interface to invalidate cache entries ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Small nit, feel free to ignore if you disagree http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.h File src/kudu/util/cache.h: http://gerrit.cloudera.org:8080/#/c/13196/2/src/kudu/util/cache.h@243 PS2, Line 243: from the oldest (less relevant) entries to the newest (more relevant) ones. > Caches with both LRU and FIFO eviction policies keep their lists organized Thanks for the explanation. This comment doesn't quite reflect that I think; for an LRU policy, the best candidate isn't the oldest, but rather, the least-recently used. Perhaps reword it slightly: "The invalidation process iterates over the cache's recency list(s), from best candidate for eviction to the worst." or somesuch? -- To view, visit http://gerrit.cloudera.org:8080/13196 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e340c3270b5580114151cdd40afe82576c18099 Gerrit-Change-Number: 13196 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 02 May 2019 19:08:34 +0000 Gerrit-HasComments: Yes
