helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 )
Change subject: [tablet] Support accurate count of rows ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13456/4//COMMIT_MSG@7 PS4, Line 7: [tablet] Support accurate count of rows > Would it be possible to add a capability to the tablet superblock to track Done http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG@33 PS6, Line 33: 8.For the historical tablets: : When a negative number is returned, it means it is a historical : tablet. And a historical tablet can return a positive number of : live rows after compaction and etc. > This isn't as clear as it could be. It's important to add that a tablet wil 1.BTW, do you think this is better than a superblock-level capability that's set for new tablets? --> It's possible to add a new field to the superblock to indicate that the newly created tablets support real live row count. But, 1) it will take up an additional field, 2) it becomes a little bit difficult to 'historical' tablet to support this feature; 2.Do you really expect tablets to eventually be fully recompacted such that every DRS has a correct live row count? I wouldn't expect that out of most workloads: often times there are sections of keyspace that are "ancient" and are probably already fully compacted. --> Hmm, maybe you are right. So, do we need to close the door for the 'ancient' tablets? 3.-1 into Status::NotSupported? --> Yea, good idea! -- To view, visit http://gerrit.cloudera.org:8080/13456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6378e289bb85024c29e96c2b153fc417ed6412 Gerrit-Change-Number: 13456 Gerrit-PatchSet: 6 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Mon, 03 Jun 2019 03:05:27 +0000 Gerrit-HasComments: Yes
