helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13456 )
Change subject: [tablet] Support accurate count of rows ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13456/6//COMMIT_MSG@33 PS6, Line 33: 7.Compact: : Just like step2. : : __counter > Ah, I see your point: because tablet copy operates at the level of data blo ^_^ http://gerrit.cloudera.org:8080/#/c/13456/7/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: PS7: > Also in RollingDiskRowSetWriter. Done http://gerrit.cloudera.org:8080/#/c/13456/7/src/kudu/tablet/tablet_metadata.cc File src/kudu/tablet/tablet_metadata.cc: http://gerrit.cloudera.org:8080/#/c/13456/7/src/kudu/tablet/tablet_metadata.cc@272 PS7, Line 272: const TabletDataState& tablet_data_state, > Ah, right. I forgot to remove this suggestion after reviewing that; sorry. it doesn't matter :) http://gerrit.cloudera.org:8080/#/c/13456/9/src/kudu/tserver/tablet_copy-test-base.h File src/kudu/tserver/tablet_copy-test-base.h: http://gerrit.cloudera.org:8080/#/c/13456/9/src/kudu/tserver/tablet_copy-test-base.h@113 PS9, Line 113: virtual void GenerateTestData() { > Why does this need to be virtual? I want to inject the modification of the 'supports_live_row_count' through polymorphism characteristic. Please look at L147 in tserver/tablet_copy_client-test.cc. And I think that's a simplest way to support your first comment in https://gerrit.cloudera.org/#/c/13456/7/src/kudu/tserver/tablet_copy_client.cc -- To view, visit http://gerrit.cloudera.org:8080/13456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e6378e289bb85024c29e96c2b153fc417ed6412 Gerrit-Change-Number: 13456 Gerrit-PatchSet: 9 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Tue, 04 Jun 2019 04:57:44 +0000 Gerrit-HasComments: Yes
