Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 )
Change subject: hms: allow for tooling to run without Kudu plugin ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/master/master.cc File src/kudu/master/master.cc: http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/master/master.cc@123 PS2, Line 123: // Note: this check only needs to be run on a server. E.g. tools that run with I don't know the answer, but it seems like there should be a more exact way to check if running in a master or tserver. This could be surprising down the road if configuration expectations change. -- To view, visit http://gerrit.cloudera.org:8080/13510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b9968bf0f8a55859a14421beda05cab3496b6c0 Gerrit-Change-Number: 13510 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 04 Jun 2019 20:24:45 +0000 Gerrit-HasComments: Yes
