Hao Hao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13510 )

Change subject: hms: allow for tooling to run without Kudu plugin
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG@27
PS2, Line 27: kserver
nit: tserver?


http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG@31
PS2, Line 31: an
nit: a


http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto
File src/kudu/common/common.proto:

http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto@81
PS2, Line 81: configured to listen to Kudu
I think this comment is a bit misleading. If the only difference is to enabled 
Kudu plugin. Could you rephrase it to 'The HMS will be started and configured 
to use Kudu plugin,...' ?


http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto@85
PS2, Line 85: configured to listen to Kudu
Same here.


http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/hms/mini_hms.h
File src/kudu/hms/mini_hms.h:

http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/hms/mini_hms.h@63
PS2, Line 63: EnableKuduListener
nit: rename to EnableKuduPlugin?



-- 
To view, visit http://gerrit.cloudera.org:8080/13510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b9968bf0f8a55859a14421beda05cab3496b6c0
Gerrit-Change-Number: 13510
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 05 Jun 2019 00:40:17 +0000
Gerrit-HasComments: Yes

Reply via email to