Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13510 )
Change subject: hms: allow for tooling to run without Kudu plugin ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG@27 PS2, Line 27: server. > nit: tserver? Done http://gerrit.cloudera.org:8080/#/c/13510/2//COMMIT_MSG@31 PS2, Line 31: > nit: a Reading this out loud, this reads more naturally. http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto File src/kudu/common/common.proto: http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto@81 PS2, Line 81: > I think this comment is a bit misleading. If the only difference is to enab Done http://gerrit.cloudera.org:8080/#/c/13510/2/src/kudu/common/common.proto@85 PS2, Line 85: > Same here. Done http://gerrit.cloudera.org:8080/#/c/13510/3/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/13510/3/src/kudu/server/server_base.cc@208 PS3, Line 208: is_server > This looks good and generic, but as a second thought, I'm curious whether a I'm leaving this as is unless you feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/13510 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b9968bf0f8a55859a14421beda05cab3496b6c0 Gerrit-Change-Number: 13510 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Jun 2019 20:24:33 +0000 Gerrit-HasComments: Yes
