Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 )
Change subject: sentry: avoid authorizing every table in ListTables ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/13549/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13549/1//COMMIT_MSG@32 PS1, Line 32: patch. A follow-up patch will make this more performant by caching : privileges from requests at the database scope. : : Iterating through one database and no tables since the user has > I'm still digging into why this is so close to the third case, since I foun I was expecting this to be lower than the third case since it's only doing a lookup on the database. I hadn't taken into account that when running the test and granting database-level privileges, there'd be more stuff in Sentry, so authorization is slightly slower. I've updated this in the new revision. -- To view, visit http://gerrit.cloudera.org:8080/13549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c495c635fbd2a661709b6d7f04973b7864b5527 Gerrit-Change-Number: 13549 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 07 Jun 2019 00:36:30 +0000 Gerrit-HasComments: Yes