Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 )
Change subject: sentry: avoid authorizing every table in ListTables ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13549/6/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/13549/6/src/kudu/master/sentry_authz_provider.cc@196 PS6, Line 196: unordered_map<string, vector<string>> tables_by_db; Might find an unordered_multimap easier to work with. http://gerrit.cloudera.org:8080/#/c/13549/6/src/kudu/master/sentry_authz_provider.cc@201 PS6, Line 201: if (!s.ok()) { : continue; : } This is interesting: you sure we don't want to pretend a table with a non-conformant name has been authorized? How does such a table behave during other catalog manager operations? -- To view, visit http://gerrit.cloudera.org:8080/13549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c495c635fbd2a661709b6d7f04973b7864b5527 Gerrit-Change-Number: 13549 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 04:24:10 +0000 Gerrit-HasComments: Yes
