Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13566 )
Change subject: authz: refactor authorization for ListTables ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/catalog_manager.cc@2843 PS4, Line 2843: } : return Status: > How about just doing this on L2833/L2838 instead of intermediating through Done http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/13566/4/src/kudu/master/sentry_authz_provider.cc@197 PS4, Line 197: *checked_table_names = true; > If table_names was empty, should this still be true? It doesn't affect the logic either way, but conceptually yes because the (albeit empty list of) tables that were passed in were checked. -- To view, visit http://gerrit.cloudera.org:8080/13566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568e1be7b909768a99f0f4f13775e34a01ccd160 Gerrit-Change-Number: 13566 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 05:48:41 +0000 Gerrit-HasComments: Yes
