Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13566 )
Change subject: authz: refactor authorization for ListTables ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13566/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/13566/5/src/kudu/master/catalog_manager.cc@2840 PS5, Line 2840: table->set_id(FindOrDie(table_info_by_name, table_name)->id()); Maybe just iterate over table_info_by_name instead of table_names? The map's keys won't reflect any concurrent rename so you should be safe there. -- To view, visit http://gerrit.cloudera.org:8080/13566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I568e1be7b909768a99f0f4f13775e34a01ccd160 Gerrit-Change-Number: 13566 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 16:20:08 +0000 Gerrit-HasComments: Yes
