Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13549 )
Change subject: sentry: avoid authorizing every table in ListTables ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13549/6/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/13549/6/src/kudu/master/sentry_authz_provider.cc@196 PS6, Line 196: *checked_table_names = false; > multimap::equal_range() gives you that grouped lookup functionality. Ah neat, thanks for the pointer. Really the functionality I want is grouped iteration, which IIUC isn't as straight-forward with multimaps. At least, I started refactoring to use multimap, but found it easier to reason about a map of containers. -- To view, visit http://gerrit.cloudera.org:8080/13549 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c495c635fbd2a661709b6d7f04973b7864b5527 Gerrit-Change-Number: 13549 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 10 Jun 2019 17:51:21 +0000 Gerrit-HasComments: Yes
