Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13757 )
Change subject: [docs] update Hive Metastore integration and Impala integration docs ...................................................................... Patch Set 1: (8 comments) Took a quick first glance. More to follow. Thank you for putting up this doc! http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc File docs/hive_metastore.adoc: http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@95 PS1, Line 95: work flow nit: workflow http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@105 PS1, Line 105: ptions available with `hms` Is this about sub-actions of 'hms' or options of 'hms check'? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@108 PS1, Line 108: e.g, i.e. ? Maybe, instead of introducing 'super privileges', rephrase to state that the admin user should be added into the list of trusted users that bypass fine-grained authz, i.e. add the name of the user into the `--trusted_user_acl`. Or you that's more about a choice granting the admin user ALL on everything in the Kudu cluster vs adding it into the `--trusted_user_acl`? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@113 PS1, Line 113: check precheck? http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@114 PS1, Line 114: exist drop http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@123 PS1, Line 123: Hive-specific Shell such as Impala this looks a bit confusing to me. First, probably you meant impala-shell, not Impala, right? Second, maybe drop mention of Hive-specific Shell and rephrase as: ... require using impala-shell for fixing. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@129 PS1, Line 129: dryrun --dryrun http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@175 PS1, Line 175: renam_table rename_table -- To view, visit http://gerrit.cloudera.org:8080/13757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8726a39d56c4e9954f208700e99e7bcf2bbc290d Gerrit-Change-Number: 13757 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 28 Jun 2019 19:18:40 +0000 Gerrit-HasComments: Yes
