Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13757 )
Change subject: [docs] update Hive Metastore integration and Impala integration docs ...................................................................... Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc File docs/hive_metastore.adoc: PS1: > Do you think it's worth mentioning here that turning the integration on mea Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@92 PS1, Line 92: `kudu hms check` and `kudu hms fix` > Should mention `precheck` too? Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@95 PS1, Line 95: work flow > nit: workflow Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@102 PS1, Line 102: master-01.example.com,master-02.example.com,master-03.example.com > Is the constraint here that this must match exactly with the value of some Yes, but also to ensure you always present the leader master. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@105 PS1, Line 105: ptions available with `hms` > Is this about sub-actions of 'hms' or options of 'hms check'? This is about sub-actions of 'hms'. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@108 PS1, Line 108: e.g, > i.e. ? Yeah, I think both should work. Though I think the later is more universal(when other authorization method is integrated). Rephrase to be more clear. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@108 PS1, Line 108: super > Superuser has a special meaning in Kudu. We probably mean "trusted user" he Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@113 PS1, Line 113: check > precheck Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@114 PS1, Line 114: exist > drop Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@123 PS1, Line 123: Hive-specific Shell such as Impala > this looks a bit confusing to me. First, probably you meant impala-shell, Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@123 PS1, Line 123: Impala > Should probably be `impala-shell`. Also, no beeline? No, I don't think we expect to use beeline to fix Impala tables. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@129 PS1, Line 129: dryrun > --dryrun Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@132 PS1, Line 132: : ## Upgrading Existing Tables > I'm not sure how this renders. Will it be obvious that this should be done You are right. I think it makes more sense to complete everything that a user, with a fresh Kudu(1.10) install, needs to know before moving to 'upgrading'. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@160 PS1, Line 160: . Note down all external tables. This can be helpful if catalog upgrade breaks any : external tables, due to the underlying Kudu tables being renamed. > Is there a command for this in Impala? This can be done using 'Kudu hms list' tool, added. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@169 PS1, Line 169: : . (Optional) If `kudu hms precheck` tool reports conflicting tables, rename these to : case-insensitive unique names using the following command: > Why is this optional? Sorry for the confusion. I mean it is optional if you have a good run of `precheck` tool. http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@175 PS1, Line 175: renam_table > rename_table Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@184 PS1, Line 184: Whether to ignore separate Kudu clusters that indicated by different set of master addresses (even only differ by port number). > nit: Whether to ignore Kudu clusters that are different than the one being Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@194 PS1, Line 194: dry run `kudu hms fix` tool > nit: perform a dry-run of the `kudu hms fix` tool Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@201 PS1, Line 201: ignores_other_clusters > ignore Done http://gerrit.cloudera.org:8080/#/c/13757/1/docs/hive_metastore.adoc@211 PS1, Line 211: Manually fix issues reported by the check tool but cannot be automatically fixed. : For example, rename Hive-incompatible tables. : > Manually fix any issues that are reported by the check tool that cannot be Done -- To view, visit http://gerrit.cloudera.org:8080/13757 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8726a39d56c4e9954f208700e99e7bcf2bbc290d Gerrit-Change-Number: 13757 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 30 Jun 2019 20:18:20 +0000 Gerrit-HasComments: Yes
