Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 )
Change subject: [hms] Sync external HMS tables with purge property ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/14179/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14179/2//COMMIT_MSG@13 PS2, Line 13: Hive tables Does it matter if they are managed or external originally? http://gerrit.cloudera.org:8080/#/c/14179/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/14179/2/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@233 PS2, Line 233: altering Did this test alter the table? What is the rationale behind the test? http://gerrit.cloudera.org:8080/#/c/14179/2/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14179/2/src/kudu/hms/hms_catalog.cc@215 PS2, Line 215: // Remove the Kudu-specific field 'kudu.table_id'. Removing the managed table validation should not bring any issues, as it will be a no-op for tables that has not id, right? http://gerrit.cloudera.org:8080/#/c/14179/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14179/2/src/kudu/tools/kudu-tool-test.cc@3694 PS2, Line 3694: external table nit: external table with purge key to be true. http://gerrit.cloudera.org:8080/#/c/14179/2/src/kudu/tools/kudu-tool-test.cc@3757 PS2, Line 3757: external table nit: external table with purge key to be true (need to be synchronized). -- To view, visit http://gerrit.cloudera.org:8080/14179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942515c015b1a4a63cf08383c331c4e19350c312 Gerrit-Change-Number: 14179 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 06 Sep 2019 17:51:04 +0000 Gerrit-HasComments: Yes
