Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 )
Change subject: [hms] Sync external HMS tables with purge property ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/14179/4/src/kudu/hms/hms_catalog.cc File src/kudu/hms/hms_catalog.cc: http://gerrit.cloudera.org:8080/#/c/14179/4/src/kudu/hms/hms_catalog.cc@189 PS4, Line 189: // If this is an external table, only upgrade the storage handler. : if (table.tableType == HmsClient::kExternalTable) { : table.parameters[HmsClient::kStorageHandlerKey] = HmsClient::kKuduStorageHandler; : } Sorry missed this in last review, do we need to check for external.table.purge key here as well? -- To view, visit http://gerrit.cloudera.org:8080/14179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942515c015b1a4a63cf08383c331c4e19350c312 Gerrit-Change-Number: 14179 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 09 Sep 2019 19:02:00 +0000 Gerrit-HasComments: Yes
