Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14179 )
Change subject: [hms] Sync external HMS tables with purge property ...................................................................... Patch Set 6: (1 comment) LGTM, just one more test case to have better coverage. http://gerrit.cloudera.org:8080/#/c/14179/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/14179/6/src/kudu/tools/kudu-tool-test.cc@3775 PS6, Line 3775: // Test case: legacy managed table. Sorry that I should mention in the previous comment, can you also add a test case for legacy external table with purge key? -- To view, visit http://gerrit.cloudera.org:8080/14179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I942515c015b1a4a63cf08383c331c4e19350c312 Gerrit-Change-Number: 14179 Gerrit-PatchSet: 6 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 10 Sep 2019 19:59:42 +0000 Gerrit-HasComments: Yes
