Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 )
Change subject: KUDU-2069 p1: add persistent tserver maintenance mode ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/catalog_manager.cc@5017 PS3, Line 5017: GetTableLocationsResponsePB* resp, > warning: the parameter 'user' is copied for each invocation but only used a Ack http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_manager.cc File src/kudu/master/ts_manager.cc: http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_manager.cc@63 PS3, Line 63: > warning: using decl 'vector' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_state-test.cc File src/kudu/master/ts_state-test.cc: http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_state-test.cc@211 PS3, Line 211: } > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_state-test.cc@232 PS3, Line 232: } > warning: 'emplace_back' is called inside a loop; consider pre-allocating th Done http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_state.h File src/kudu/master/ts_state.h: http://gerrit.cloudera.org:8080/#/c/14217/3/src/kudu/master/ts_state.h@94 PS3, Line 94: > warning: namespace 'kudu' ends with an unrecognized comment [google-readabi Done -- To view, visit http://gerrit.cloudera.org:8080/14217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib669b43b3cee171c4c7dbd54041e29c30cb9f767 Gerrit-Change-Number: 14217 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Sep 2019 17:56:05 +0000 Gerrit-HasComments: Yes
