Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14217 )
Change subject: KUDU-2069 p1: add persistent tserver maintenance mode ...................................................................... Patch Set 7: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/14217/6/src/kudu/master/ts_manager.h File src/kudu/master/ts_manager.h: http://gerrit.cloudera.org:8080/#/c/14217/6/src/kudu/master/ts_manager.h@122 PS6, Line 122: mutable RWMutex ts_state_lock_; > It's significantly less complex to implement and to reason about the lockin OK, but FWIW the complex locking you're alluding to already exists within TSDescriptor (lock_) and TSManager (lock_), so you wouldn't be adding any new complexity. I don't feel strongly though. -- To view, visit http://gerrit.cloudera.org:8080/14217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib669b43b3cee171c4c7dbd54041e29c30cb9f767 Gerrit-Change-Number: 14217 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 17 Sep 2019 21:37:55 +0000 Gerrit-HasComments: Yes
