Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14395 )
Change subject: KUDU-2965: cut down on task-related log spew in the catalog manager ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/14395/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/14395/1//COMMIT_MSG@14 PS1, Line 14: throttling across a particular : facet (e.g. per tserver) but the complexity outweighs the usefulness. While I agree here, this kind of throttling would be super useful for per-replica throttling on tservers. http://gerrit.cloudera.org:8080/#/c/14395/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/14395/1/src/kudu/master/catalog_manager.cc@3252 PS1, Line 3252: 1 > nit: maybe, 60 seconds is a better option? Yeah, I've never found a good formula for how frequently we should update these. On the one hand, 1 second over a long period will still fill the logs. On the other, 60 seconds might be too coarse-grained to pinpoint something useful. I think I'd be fine with either; this already seems like an improvement over what there was before. -- To view, visit http://gerrit.cloudera.org:8080/14395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d852eefdcb7903f6cfa330a423744a0ca5b7e80 Gerrit-Change-Number: 14395 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Oct 2019 01:48:06 +0000 Gerrit-HasComments: Yes
