Hello Alexey Serbin, Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14395
to look at the new patch set (#2).
Change subject: KUDU-2965: cut down on task-related log spew in the catalog
manager
......................................................................
KUDU-2965: cut down on task-related log spew in the catalog manager
- All "sending RPC" messages are relegated to VLOG. These aren't terribly
useful in troubleshooting (i.e. the tserver's log is the source of truth
for what RPCs were actually received), and it was already the case for
some tasks, so it made sense to do it across the board.
- Failure messages that don't end a task are throttled because they're very
likely to repeat. I thought about throttling across a particular facet
(e.g. per tserver) but that's more work than what I want to do right now.
- Generic retry messages are relegated to VLOG. Sure it was nice to see the
exponential backoff get logged, but after years of that, I think we know
that the math works as expected.
- A few other cosmetic changes, including the removal of a function that had
no effect since the dawn of time.
Change-Id: I6d852eefdcb7903f6cfa330a423744a0ca5b7e80
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
2 files changed, 43 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/14395/2
--
To view, visit http://gerrit.cloudera.org:8080/14395
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d852eefdcb7903f6cfa330a423744a0ca5b7e80
Gerrit-Change-Number: 14395
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
