Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 22: (1 comment) http://gerrit.cloudera.org:8080/#/c/14306/22/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/14306/22/src/kudu/tools/tool_action_table.cc@1095 PS22, Line 1095: // test code end > I add a test here. CreateTablePB is defined as: That's certainly unexpected. But it's workable: as long as we reserve 0 for the UNKNOWN value, we'll ensure that both missing values and unknown values return an error per your ToClientEncodingType and equivalent functions. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 22 Gerrit-Owner: YangSong <sy1...@yeah.net> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <sy1...@yeah.net> Gerrit-Comment-Date: Fri, 18 Oct 2019 23:00:54 +0000 Gerrit-HasComments: Yes
