Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14306 )
Change subject: add a tool to create table ...................................................................... Patch Set 25: > Ok, I'll try to modify it as you said. It would be nice if you could provide > a similar example in the test code. Like I said, you've already done a ton of work so don't feel compelled to do that. But if you insist, here are some examples: - FsManagerTestBase_TestAddRemoveDataDirsFuzz (fs_manager-test.cc) - LogBlockManagerTest_TestMisalignedBlocksFuzz (log_block_manager-test.cc) - fuzz-itest.cc The common theme behind these tests is that it's too expensive to exhaustively test every possible combination of test input. So instead, the tests randomly generate one possible set of input and applies it. One test iteration doesn't tell us much, but the entire Kudu test suite runs over and over in precommit and in hourly/daily runs, so over time, we'll eventually cover most combinations and will know whether a particular combination fails. -- To view, visit http://gerrit.cloudera.org:8080/14306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0bce4733a504f8ef5f024089a16fe3c6f1e493f1 Gerrit-Change-Number: 14306 Gerrit-PatchSet: 25 Gerrit-Owner: YangSong <sy1...@yeah.net> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <sy1...@yeah.net> Gerrit-Comment-Date: Wed, 23 Oct 2019 04:03:20 +0000 Gerrit-HasComments: No