Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 )
Change subject: [tablet] Use std::deque instead of std::vector to collect blocks ...................................................................... Patch Set 3: (4 comments) Might be nice to typedef a BlockIdContainer (as std::deque<BlockId>) in block_id.h and use it universally. Then if we ever change our minds we only have to update one place. http://gerrit.cloudera.org:8080/#/c/14445/3//COMMIT_MSG Commit Message: PS3: Could you summarize your perf results into the commit message? http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@87 PS3, Line 87: TabletMetadata::Load(harness_->fs_manager(), : harness_->tablet()->tablet_id(), : &tablet_meta_); Couldn't you just reference tablet()->tablet_metadata() to get the already-loaded TabletMetadata? http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@100 PS3, Line 100: CHECK_OK(RowSetMetadata::CreateNew(tablet_meta_.get(), i, &meta)); Nit: ASSERT_OK. http://gerrit.cloudera.org:8080/#/c/14445/3/src/kudu/tablet/tablet_metadata-test.cc@102 PS3, Line 102: std:: Add a using for this. -- To view, visit http://gerrit.cloudera.org:8080/14445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce853e35eb7dfa9f9a099e465ea8edfaa7c4aa9 Gerrit-Change-Number: 14445 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Thu, 14 Nov 2019 06:27:43 +0000 Gerrit-HasComments: Yes
