Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/14445 )
Change subject: [tablet] Use std::deque instead of std::vector to collect blocks ...................................................................... Patch Set 4: (1 comment) > Patch Set 4: > > > Might be nice to typedef a BlockIdContainer (as std::deque<BlockId>) in > > block_id.h and use it universally. Then if we ever change our minds we only > > have to update one place. > > I think you missed this suggestion. Missed it indeed :( Done. http://gerrit.cloudera.org:8080/#/c/14445/4/src/kudu/tablet/tablet_metadata-test.cc File src/kudu/tablet/tablet_metadata-test.cc: http://gerrit.cloudera.org:8080/#/c/14445/4/src/kudu/tablet/tablet_metadata-test.cc@219 PS4, Line 219: LOG(INFO) << "block_ids size: " << block_ids.size(); > It would be nice to move this out of the timing scope. Done -- To view, visit http://gerrit.cloudera.org:8080/14445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7ce853e35eb7dfa9f9a099e465ea8edfaa7c4aa9 Gerrit-Change-Number: 14445 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Fri, 15 Nov 2019 02:10:21 +0000 Gerrit-HasComments: Yes
