Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 )
Change subject: KUDU-3005: Reduce size of kudu-python docker image ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile@66 PS2, Line 66: RUN ./bootstrap-dev-env.sh \ : && ./bootstrap-python-env.sh \ : && rm bootstrap-dev-env.sh \ : && rm bootstrap-python-env.sh Why not separate this into two different RUN statements, each for a particular script? http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile@256 PS2, Line 256: python Python http://gerrit.cloudera.org:8080/#/c/14984/2/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: PS2: A fair amount of this is duplicated from bootstrap-dev-env.sh. Could you refactor to avoid the duplication? For example, install_python_packages() could be defined in a common file that's sourced by both. Same for the pre-install and post-install steps. -- To view, visit http://gerrit.cloudera.org:8080/14984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I159907c4a85e919d98c92df97cd44d0300d1cd29 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Jan 2020 22:05:21 +0000 Gerrit-HasComments: Yes
