Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14984 )
Change subject: KUDU-3005: Reduce size of kudu-python docker image ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/14984/2/docker/Dockerfile@66 PS2, Line 66: RUN ./bootstrap-dev-env.sh \ : && ./bootstrap-python-env.sh \ : && rm bootstrap-dev-env.sh \ : && rm bootstrap-python-env.sh > Why not separate this into two different RUN statements, each for a particu IIUC each COPY/RUN/etc statement affects the checkpoints that docker creates. I think the goal of this file is image is to get us from 0 to dev, and we don't care about the in-between. http://gerrit.cloudera.org:8080/#/c/14984/2/docker/bootstrap-python-env.sh File docker/bootstrap-python-env.sh: PS2: > A fair amount of this is duplicated from bootstrap-dev-env.sh. Could you re Given how this is used (copying into the docker container and then run), I could be convinced that splitting up this already small script isn't worth it, considering the fact that we would then be forced to jump around a bunch of tiny files to read it. -- To view, visit http://gerrit.cloudera.org:8080/14984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I159907c4a85e919d98c92df97cd44d0300d1cd29 Gerrit-Change-Number: 14984 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 07 Jan 2020 23:21:33 +0000 Gerrit-HasComments: Yes
