Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14989
Change subject: consensus: throttle warnings when quiescing server ...................................................................... consensus: throttle warnings when quiescing server When an election fails to start because the server is quiescing, it will log a warning. When there are many replicas on a server, this logging can become very verbose. This throttles such logs to happen at most once per second. Here's a snippet of the logs from TestQuiescingServerDoesntTriggerElections: Before: W0107 17:55:46.943423 55670 raft_consensus.cc:655] T d1bc343b18e348ada0a4fadb835d8cc1 P f0fd8e85d7a843e6862dfd846ca47351: failed to trigger leader election: Illegal state: leader elections are disabled W0107 17:55:46.947376 55670 raft_consensus.cc:655] T 4fb4aec4dbb94dc9b2af086b761d2632 P f0fd8e85d7a843e6862dfd846ca47351: failed to trigger leader election: Illegal state: leader elections are disabled W0107 17:55:46.949579 55670 raft_consensus.cc:655] T 49bf5837ae0c4d95bf1a176a856c9f37 P f0fd8e85d7a843e6862dfd846ca47351: failed to trigger leader election: Illegal state: leader elections are disabled W0107 17:55:46.992861 55670 raft_consensus.cc:655] T 842d307a87f846efa00bbf0a537fe812 P f0fd8e85d7a843e6862dfd846ca47351: failed to trigger leader election: Illegal state: leader elections are disabled After: W0107 18:04:42.348387 64502 raft_consensus.cc:655] T 346a0544fe95444eb3becd158f40135c P 66f6cf3b32b94f7e9eacd1f012a4386f: failed to trigger leader election: Illegal state: leader elections are disabled [suppressed 21 similar messages] While it would be nice to retain logs for every replica for grep-ability, I think the improved readability of the logs justifies the loss. Change-Id: I01e3c88c2bd4c53d095b9b5a061439231dcfc9e9 --- M src/kudu/consensus/raft_consensus.cc M src/kudu/util/logging.h 2 files changed, 13 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/14989/1 -- To view, visit http://gerrit.cloudera.org:8080/14989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I01e3c88c2bd4c53d095b9b5a061439231dcfc9e9 Gerrit-Change-Number: 14989 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
