Hello Tidy Bot, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14989
to look at the new patch set (#2).
Change subject: consensus: throttle warnings when quiescing server
......................................................................
consensus: throttle warnings when quiescing server
When an election fails to start because the server is quiescing, it will
log a warning. When there are many replicas on a server, this logging
can become very verbose.
This throttles such logs to happen at most once per ten seconds. Here's
a snippet of the logs from TestQuiescingServerDoesntTriggerElections:
Before:
W0107 17:55:46.943423 55670 raft_consensus.cc:655] T
d1bc343b18e348ada0a4fadb835d8cc1 P f0fd8e85d7a843e6862dfd846ca47351: failed to
trigger leader election: Illegal state: leader elections are disabled
W0107 17:55:46.947376 55670 raft_consensus.cc:655] T
4fb4aec4dbb94dc9b2af086b761d2632 P f0fd8e85d7a843e6862dfd846ca47351: failed to
trigger leader election: Illegal state: leader elections are disabled
W0107 17:55:46.949579 55670 raft_consensus.cc:655] T
49bf5837ae0c4d95bf1a176a856c9f37 P f0fd8e85d7a843e6862dfd846ca47351: failed to
trigger leader election: Illegal state: leader elections are disabled
W0107 17:55:46.992861 55670 raft_consensus.cc:655] T
842d307a87f846efa00bbf0a537fe812 P f0fd8e85d7a843e6862dfd846ca47351: failed to
trigger leader election: Illegal state: leader elections are disabled
After:
W0107 19:16:47.518998 87519 raft_consensus.cc:655] T
1e0aed8879c643d6a8684f6da729a1a3 P 14907cae807b4560b4b8417ba5f24393: failed to
trigger leader election: Illegal state: leader elections are disabled
(in After, the test didn't last 10 seconds)
While it would be nice to retain logs for every replica for grep-ability, I
think the improved readability of the logs justifies the loss.
Change-Id: I01e3c88c2bd4c53d095b9b5a061439231dcfc9e9
---
M src/kudu/consensus/raft_consensus.cc
M src/kudu/util/logging.h
2 files changed, 13 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/14989/2
--
To view, visit http://gerrit.cloudera.org:8080/14989
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I01e3c88c2bd4c53d095b9b5a061439231dcfc9e9
Gerrit-Change-Number: 14989
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
