Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 )
Change subject: [python] Fix Python 3 syntax issues ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py File build-support/parse_test_failure.py: http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py@292 PS1, Line 292: open(os.path.join(self._TEST_DIR, child)).read() Nit: In this case I think we are relying on Python's garbage collector to close the file. Would it be better to explicitly close the file using with clause/finally close() or this is not long running enough to cause resource leak issue? Same for couple of other places below. http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py File src/kudu/scripts/max_skew_estimate.py: http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py@87 PS1, Line 87: print("%02d percentile: %d" % (p, percentile(skews, p))) Nit: I think this print formatting is considered old-style and newer style is to use "".format(). Something to consider changing while making the compatibility change. -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 18:06:09 +0000 Gerrit-HasComments: Yes
