Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15037 )
Change subject: [python] Fix Python 3 syntax issues ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py File build-support/parse_test_failure.py: http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/parse_test_failure.py@292 PS1, Line 292: open(os.path.join(self._TEST_DIR, child)).read() > Nit: In this case I think we are relying on Python's garbage collector to c Done http://gerrit.cloudera.org:8080/#/c/15037/1/build-support/release/rat_exclude_files.txt File build-support/release/rat_exclude_files.txt: PS1: > If you're feeling charitable you can break this change out into a separate Done PS1: > Good catch. I meant to. This was just found while testing some of the Pytho Done http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py File src/kudu/scripts/max_skew_estimate.py: http://gerrit.cloudera.org:8080/#/c/15037/1/src/kudu/scripts/max_skew_estimate.py@87 PS1, Line 87: print("%02d percentile: %d" % (p, percentile(skews, p))) > Nit: I think this print formatting is considered old-style and newer style Done -- To view, visit http://gerrit.cloudera.org:8080/15037 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d5e06ea6299032d84a76440afb42a70fd461abd Gerrit-Change-Number: 15037 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 15 Jan 2020 20:34:29 +0000 Gerrit-HasComments: Yes
