Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15070 )
Change subject: [clock] auto-config of built-in NTP client in cloud ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc@593 PS1, Line 593: RETURN_NOT_OK_PREPEND(HostPort::ParseStrings(FLAGS_builtin_ntp_servers, : kStandardNtpPort, &hps), : "could not parse --builtin_ntp_servers flag"); > Do you think we should also use these servers in addition to the cloud-prov I'm not sure these are needed by default if using the NTP server provided by the cloud infrastructure itself, because these * might be blocked by firewall * might be too far in terms of RTT and thus wouldn't constitute a set of good-enough candidates for time synchronization Maybe, we should add a flag to add those if really needed? Not sure what might be a use-case that justifies for adding those in addition to the NTP server provided from within a cloud instance. -- To view, visit http://gerrit.cloudera.org:8080/15070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0590c0b731a4da2f968e720dea0410d46ab62beb Gerrit-Change-Number: 15070 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 Jan 2020 20:42:16 +0000 Gerrit-HasComments: Yes
