Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15070 )
Change subject: [clock] auto-config of built-in NTP client in cloud ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc File src/kudu/clock/builtin_ntp.cc: http://gerrit.cloudera.org:8080/#/c/15070/1/src/kudu/clock/builtin_ntp.cc@593 PS1, Line 593: "could not parse --builtin_ntp_servers flag"); : } : RETURN_NOT_OK(PopulateServers(std::move(hps))); > I'm not sure these are needed by default if using the NTP server provided b We could probably skip for now. -- To view, visit http://gerrit.cloudera.org:8080/15070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0590c0b731a4da2f968e720dea0410d46ab62beb Gerrit-Change-Number: 15070 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 Jan 2020 17:33:14 +0000 Gerrit-HasComments: Yes
