Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15082 )
Change subject: log: start using file cache ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/consensus/log.cc@1071 PS1, Line 1071: // Note: the segment files will only be deleted from disk when : // segments_to_delete goes out of scope. nit: Is this important? Could we iterate by mutable ref and reset the references in segments_to_delete? http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tserver/ts_tablet_manager.cc@1127 PS1, Line 1127: server_->file_cache(), Using the file cache means there's a performance hit every time we allocate/roll onto new WAL segments, and it adds stress on data block pathways as well. Do you think we ought to add a flag that enables this? -- To view, visit http://gerrit.cloudera.org:8080/15082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c00f6b839a693e059fa2ce79abf347dbf83bdd0 Gerrit-Change-Number: 15082 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 Jan 2020 22:37:06 +0000 Gerrit-HasComments: Yes