Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15082 )
Change subject: log: start using file cache ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/15082/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15082/1//COMMIT_MSG@19 PS1, Line 19: unsafe to delete a : log's data or bootstrap a new copy of an existing tablet without first : closing the old log > Is it possible to track such conditions and add CHECK()/DCHECK() correspond Check out the comments I added to Log::DeleteOnDiskData and Log::RemoveRecoveryDirIfExists. Both are static functions, called from the static TSTabletManager::DeleteTabletData, and therein lies the problem: making that stuff non-static is tough because sometimes it's used with a corresponding Log instance and sometimes not. http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/consensus/log.cc@1071 PS1, Line 1071: ops_str = Substitute(" (ops $0-$1)", : segment->footer().m > nit: Is this important? Could we iterate by mutable ref and reset the refer We could but no, it's not important: any deleted file will be actually deleted when the function returns. I just left that comment there as a point of curiosity. http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tablet/tablet_bootstrap.cc@a729 PS1, Line 729: : : > good catch! Ack http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/15082/1/src/kudu/tserver/ts_tablet_manager.cc@1127 PS1, Line 1127: server_->file_cache(), > Using the file cache means there's a performance hit every time we allocate Yeah, that's probably wise. Done. -- To view, visit http://gerrit.cloudera.org:8080/15082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c00f6b839a693e059fa2ce79abf347dbf83bdd0 Gerrit-Change-Number: 15082 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 22 Jan 2020 17:02:36 +0000 Gerrit-HasComments: Yes
