Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15091 )
Change subject: KUDU-3011 p7: add tool to quiesce server ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15091/3/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/15091/3/src/kudu/tools/tool_action_tserver.cc@51 PS3, Line 51: DEFINE_int32(quiescing_request_period_secs, 1, "Period in seconds with which " : "the tool will check whether the tserver has finished quiescing."); : : DEFINE_int32(quiescing_timeout_secs, 30, "Amount of time in seconds the " : "tool will attempt to wait to quiesce a tablet server before giving up."); > I don't have really strong opinions on it, but I expect the pattern to be r By forcing composition into the users' hands, we allow them to do more powerful customization (e.g. emitting a helpful message in between attempts, counting the total number of attempts, giving up after a fixed number of attempts instead of a deadline, etc.). I also can't find an existing instance of our CLI tool behaving in this more "composed" way (vs. the simpler or "decomposed" way). The rebalancer comes close (i.e. number of moves, time between moves), but it's a fairly monolithic thing that'd be tricky to decompose because of its intermediate state. -- To view, visit http://gerrit.cloudera.org:8080/15091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89657808cc2b0afc4e1b37ce75937ab12e098d9c Gerrit-Change-Number: 15091 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 22 Jan 2020 18:34:46 +0000 Gerrit-HasComments: Yes
