Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15091 )
Change subject: KUDU-3011 p7: add tool to quiesce server ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15091/3/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/15091/3/src/kudu/tools/tool_action_tserver.cc@51 PS3, Line 51: DEFINE_int32(quiescing_request_period_secs, 1, "Period in seconds with which " : "the tool will check whether the tserver has finished quiescing."); : : DEFINE_int32(quiescing_timeout_secs, 30, "Amount of time in seconds the " : "tool will attempt to wait to quiesce a tablet server before giving up."); > I suppose, but we would also be forcing composition into the users' hands. Well, users must already use a scripting language to build a complete rolling restart or graceful decommission workflow, right? And going back to my earlier point: as far as I can tell, the look and feel of our CLI, currently, is "simple and decomposed". Having all commands and sub-commands adhere to that philosophy makes the tool more predictable and discoverable. -- To view, visit http://gerrit.cloudera.org:8080/15091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89657808cc2b0afc4e1b37ce75937ab12e098d9c Gerrit-Change-Number: 15091 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 22 Jan 2020 19:12:17 +0000 Gerrit-HasComments: Yes