Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 )
Change subject: KUDU-3063: Set a ratio to reserve some nvm memory ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@77 PS1, Line 77: Due to the fragmentation from memkind, we cannot use nvm capacity fully. This reads more like a comment than description of the config flag. http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@78 PS1, Line 78: Nit: Unnecessary blank line. http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@80 PS1, Line 80: Nit:Is a validator needed to ensure the value is not above 1.0? -- To view, visit http://gerrit.cloudera.org:8080/15313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceb1931f5addbf76774854ca1613b6a085b577e3 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 1 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 18:15:41 +0000 Gerrit-HasComments: Yes
