Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 )
Change subject: KUDU-3063: Set a ratio to reserve some nvm memory ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc File src/kudu/util/nvm_cache.cc: http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@76 PS1, Line 76: DEFINE_double(nvm_cache_usage_ratio, 0.8, Should also tag as advanced; most users won't need to modify this. http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@79 PS1, Line 79: TAG_FLAG(nvm_cache_usage_ratio, unsafe); Why is this tagged unsafe? Is it dangerous to change the value from 0.8 to any other value (between 0 and 1)? http://gerrit.cloudera.org:8080/#/c/15313/1/src/kudu/util/nvm_cache.cc@716 PS1, Line 716: return new ShardedLRUCache(capacity * FLAGS_nvm_cache_usage_ratio, id, vmp); At cache construction time, if nvm_cache_usage_ratio isn't 1.0 we should probably log a message indicating the reduced capacity of the cache. -- To view, visit http://gerrit.cloudera.org:8080/15313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceb1931f5addbf76774854ca1613b6a085b577e3 Gerrit-Change-Number: 15313 Gerrit-PatchSet: 1 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: ye yuqiang <[email protected]> Gerrit-Comment-Date: Fri, 28 Feb 2020 19:12:47 +0000 Gerrit-HasComments: Yes
