Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/15416/10/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/10/src/kudu/ranger/ranger_client.cc@138 PS10, Line 138: const char* kMainClass = "org.apache.kudu.subprocess.ranger.RangerSubprocessMain"; Can also be declared static? http://gerrit.cloudera.org:8080/#/c/15416/10/src/kudu/ranger/ranger_client.cc@142 PS10, Line 142: string exe; : CHECK_OK(Env::Default()->GetExecutablePath(&exe)); : const string bin_dir = DirName(exe); : return FLAGS_ranger_jar_path.empty() ? JoinPathSegments(bin_dir, "kudu-subprocess.jar") : : FLAGS_ranger_jar_path; Could restructure this to early-out if !FLAGS_ranger_path.empty() without executing the rest. http://gerrit.cloudera.org:8080/#/c/15416/10/src/kudu/ranger/ranger_client.cc@187 PS10, Line 187: FLAGS_ranger_java_path Should probably call it --ranger_java_path as that's how users will be interacting with it. -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 10 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Mar 2020 05:47:00 +0000 Gerrit-HasComments: Yes
