Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 )
Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@200 PS7, Line 200: ($0) nit: parentheses usually denote something that is optional, which doesn't seem to be the case here (e.g. if I were to read this without the parens, it would be "unable to get the configured principal from for the Ranger subprocess"). http://gerrit.cloudera.org:8080/#/c/15416/7/src/kudu/ranger/ranger_client.cc@202 PS7, Line 202: argv->emplace_back("-i"); : argv->emplace_back(configured_principal); : argv->emplace_back("-k"); : argv->emplace_back(FLAGS_keytab_file); These should be 'ret'. -- To view, visit http://gerrit.cloudera.org:8080/15416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie30b835b6d44ddb51d95c587f1329bfefebeb37c Gerrit-Change-Number: 15416 Gerrit-PatchSet: 7 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 06:29:55 +0000 Gerrit-HasComments: Yes
