Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15556 )
Change subject: Add core algorithms for columnar serialization ...................................................................... Patch Set 2: (3 comments) Just passing through with a few comments. http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/columnar_serialization-test.cc File src/kudu/common/columnar_serialization-test.cc: http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/columnar_serialization-test.cc@20 PS2, Line 20: #include <stddef.h> Prefer cstddef for new code. http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/zp7.h File src/kudu/common/zp7.h: http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/zp7.h@23 PS2, Line 23: // Extract bits from 'a' corresponding to 'mask'. Want to expand on this to help differentiate between the two function calls? http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/zp7.cc File src/kudu/common/zp7.cc: http://gerrit.cloudera.org:8080/#/c/15556/2/src/kudu/common/zp7.cc@27 PS2, Line 27: // project has no header file. It has been modified as follows: Could you also reindent the file to conform to Kudu's indentation? -- To view, visit http://gerrit.cloudera.org:8080/15556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16f2993081aac54609aab4d8219ef0bf6c7708c2 Gerrit-Change-Number: 15556 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 25 Mar 2020 20:29:02 +0000 Gerrit-HasComments: Yes
