Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto File src/kudu/ranger/ranger.proto: http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@23 PS1, Line 23: → nit: We should prefer ASCII characters where we don't need to use UTF-8 http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@32 PS1, Line 32: . nit: Should be a comma instead. http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@33 PS1, Line 33: DATABSE nit: DATABASE http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger.proto@35 PS1, Line 35: DATABSE nit: DATABASE http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h File src/kudu/ranger/ranger_client.h: http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@55 PS1, Line 55: → nit: We should stick to ASCII characters wherever we can. http://gerrit.cloudera.org:8080/#/c/15566/1/src/kudu/ranger/ranger_client.h@58 PS1, Line 58: it is not : // used yet Can you elaborate on this? We do use column level privileges in FillTablePrivilegePB. -- To view, visit http://gerrit.cloudera.org:8080/15566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6 Gerrit-Change-Number: 15566 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 27 Mar 2020 19:56:50 +0000 Gerrit-HasComments: Yes
