Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15566 )
Change subject: [ranger] add more comments for Ranger privilege model ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto File src/kudu/ranger/ranger.proto: http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30 PS2, Line 30: which where http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@30 PS2, Line 30: which authorizables higher : // up on the hierarchy can imply authorizables lower on the hierarchy, e.g. : // database implies table, Nit: I'd move this into parentheses to improve the readability of the sentence. http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@34 PS2, Line 34: cannot does not http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@35 PS2, Line 35: authorizable an authorizable http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@38 PS2, Line 38: actaully actually http://gerrit.cloudera.org:8080/#/c/15566/2/src/kudu/ranger/ranger.proto@39 PS2, Line 39: with Nit: replace with "the semantics of" -- To view, visit http://gerrit.cloudera.org:8080/15566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b827d06c7657e450903333d820dc9ef9313dcd6 Gerrit-Change-Number: 15566 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 28 Mar 2020 00:20:42 +0000 Gerrit-HasComments: Yes
