Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15625 )
Change subject: [ranger] Use unique loopback for MiniRanger ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/mini-cluster/external_mini_cluster.cc@339 PS1, Line 339: string host = GetBindIpForExternalServer(0); Should add some comment here about why it's OK to use the same index as for Sentry (i.e. we'll never start a cluster with both). Come to think of it, do we actually enforce that? We probably should. http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: http://gerrit.cloudera.org:8080/#/c/15625/1/src/kudu/util/net/net_util.h@235 PS1, Line 235: // Gets a random port from the ephemeral range by binding to port 0 and letting Update to reflect the effect of 'address'. -- To view, visit http://gerrit.cloudera.org:8080/15625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id8833bb149fb2410f4f140b8fb67b1039a2f90d0 Gerrit-Change-Number: 15625 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 31 Mar 2020 23:02:11 +0000 Gerrit-HasComments: Yes
